Skip to content

Do not store ref to goto_symext in symex_dereference_statet #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2019
Merged

Do not store ref to goto_symext in symex_dereference_statet #4292

merged 2 commits into from
Feb 28, 2019

Conversation

owen-mc-diffblue
Copy link
Contributor

The goto_symext & was only used to access a namespace. Just store
a namespacet & instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Do not store ref to goto_symext in symex_dereference_statet
cae37d9 
The `goto_symext &` was only used to access a namespace. Just store
a `namespacet &` instead.
smowton
smowton approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs clang-format

Make clang-format happy
c3ce5b1 
This code wasn't edited by my commit, but was within the context lines
of the diff, which appears to mean that clang-format cares about it.
allredj
allredj reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c3ce5b1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102632379

@owen-mc-diffblue owen-mc-diffblue merged commit a554c53 into diffblue:develop Feb 28, 2019
@owen-mc-diffblue owen-mc-diffblue deleted the refactor-fields-of-symex-dereference-statet branch February 28, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@tautschnig tautschnig tautschnig approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

Assignees

@owen-mc-diffblue owen-mc-diffblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owen-mc-diffblue @smowton @tautschnig @allredj